-
Notifications
You must be signed in to change notification settings - Fork 1
feat: adds test to check session cookie setting and timezone #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namsnath
wants to merge
6
commits into
4.1
Choose a base branch
from
test/session-cookie-setting/4.1
base: 4.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2025
porcellus
requested changes
Jun 11, 2025
porcellus
requested changes
Jul 4, 2025
const { response, headers } = await signUp("public", "[email protected]", "password123"); | ||
const epUser = response.user; | ||
|
||
// Create a new session for the user, get headers from the response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used.
porcellus
requested changes
Jul 23, 2025
- `getTimezoneOffset` works on local time, not ideal for a test
porcellus
requested changes
Aug 19, 2025
assert(refreshTokenCookie, "Refresh token cookie not found"); | ||
assert(refreshTokenCookie.expires, "Refresh token cookie expiry not set"); | ||
|
||
assert(session.getUserId() === session.getRecipeUserId().getAsString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this check is relevant. What was this meant for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.